New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ci checks, order fields, fix types, and simplify logic #698

Merged

taeh98 merged 1 commit into hossein-zare:dev-5.x from taeh98:values-error

Aug 31, 2023

Collaborator

taeh98 commented Aug 31, 2023

add CI checks to check spelling and lint commit messages
order various lists of values and fields in Picker.js and index.d.ts
fix types like "any", React imports, etc in index.d.ts
add error when value and memoryRef.current.value aren't equal when items pressed in Picker.js
simplify and comment logic when item pressed in Picker.js

taeh98 force-pushed the values-error branch from 6800551 to e0261b8 Compare

August 31, 2023 13:14


          chore: add ci checks, order fields, fix types, and simplify logic

05297d0

taeh98 force-pushed the values-error branch from e0261b8 to 05297d0 Compare

August 31, 2023 13:30

taeh98 merged commit ff853e1 into hossein-zare:dev-5.x

6 of 7 checks passed

taeh98 deleted the values-error branch

August 31, 2023 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet